Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/app sentinel coverage #1117

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

gurkanguray
Copy link
Contributor

@gurkanguray gurkanguray commented Aug 25, 2024

App Sentinel Internal Unit tests added

Description

App Sentinel Internal Initialization Package's unit tests are added. Refactored the codebase for dependency injection and monkey patching.

Changes

List the major changes you have made in bullet points:

  • Change 1
  • Change 2
  • Change 3

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

App Sentinel Internal Initialization Package's unit tests are added. Refactored the codebase for dependency injection and monkey patching.

Signed-off-by: Guray Gurkan <[email protected]>
unused comment cleanups and add copyright headers

Signed-off-by: Guray Gurkan <[email protected]>
Copy link
Contributor

@v0lkan v0lkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good.

At the very least, it's increasing coverage with minimal amount of code change; which is good.

Thanks a lot for the contribution @gurkanguray .

I'll merge it and run integration tests.

If we see an instability or test failure etc, I'll let you know.

Cheers.

@v0lkan v0lkan merged commit 59a08a3 into vmware-tanzu:main Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants