Convert Internal RootKey Representation to a Struct #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volkan Özçelik <[email protected]>
fix logic error in RootKeySetInMemory() Signed-off-by: Volkan Özçelik <[email protected]>
Signed-off-by: Volkan Özçelik <[email protected]>
Signed-off-by: Volkan Özçelik <[email protected]>
v0lkan
commented
Jul 14, 2024
| @@ -28,6 +28,8 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| _ = os.Setenv("ORIGIN", *origin) | |||
There was a problem hiding this comment.
The scripts were requesting this as an environment variable, but nobody was setting it.
Origin comes from a command line parameter, and it's not an environment variable.
So we explicitly convert it for the rest of the script to use it.
v0lkan
commented
Jul 14, 2024
| @@ -32,40 +34,34 @@ var RootKeyLock sync.RWMutex | |||
| // 2. When an operator sets a new root key through VSecM Sentinel or other | |||
| // similar means. | |||
| func SetRootKeyInMemory(k string) { | |||
| RootKeyLock.Lock() | |||
| defer RootKeyLock.Unlock() | |||
| rootKeyLock.Lock() | |||
There was a problem hiding this comment.
no need to publicly expose neither rootKey, nor its lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Internal RootKey Representation to a Struct
Description
This PR converts the internally-stored root key from a String to a Struct that contains the three parts of the root key.
Changes
List the major changes you have made in bullet points:
rootKeyconverted from a string intodata.RootKeyCollection.Test Policy Compliance
Code Quality
to understand.
Documentation
Checklist
Before you submit this PR, please make sure:
especially the test policy.
under the project's license.
By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.
Thank you for your contribution to VMware Secrets Manager
🐢⚡️!