Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Refactorings #1007

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Minor Refactorings #1007

merged 10 commits into from
Jun 19, 2024

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Jun 19, 2024

  • Moved some functions to internal folders.
  • Added documentation to public methods.
  • Added a channel to liveness and readiness probes so that the code will know when the probe is ready.
  • Other enhancements.

v0lkan added 10 commits June 18, 2024 18:30
@v0lkan
Minor changes
38e8925 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Modified dockerfiles.
3a894f1 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Dockerfile update
a2bc15e 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Minor fixes
4c4ab5a 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Fix test
8e55fbe 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
minor refactoring
22a2bbc 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Dockerfile update
cf8fd6b 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
minor refactor
15b1cc1 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Minor refactoring
5be475e 
Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan
Liveness and Readiness Probe Enhancement
7e19efa 
Liveness and readiness probes new return a channel

Signed-off-by: Volkan Ozcelik <[email protected]>
@v0lkan v0lkan self-assigned this Jun 19, 2024
@v0lkan v0lkan requested a review from BulldromeQ as a code owner June 19, 2024 11:22
@v0lkan v0lkan merged commit f2ef225 into main Jun 19, 2024
@v0lkan v0lkan deleted the ovolkan/minor branch June 19, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BulldromeQ BulldromeQ Awaiting requested review from BulldromeQ BulldromeQ is a code owner

Assignees

@v0lkan v0lkan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@v0lkan