Adapt to new apiVersion for controllers #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
from
39581d8 to
95c04e4
Compare
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
8 times, most recently
from
07c25f8 to
0926f63
Compare
timdengyun
reviewed
Jul 24, 2024
|
squash two commits into one commit. |
zhengxiexie
changed the title
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
from
0926f63 to
f292fd0
Compare
zhengxiexie
changed the title
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
5 times, most recently
from
3579ac1 to
3d38067
Compare
tnqn
reviewed
Jul 30, 2024
zhengxiexie
changed the title
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
4 times, most recently
from
8551fef to
e1cc758
Compare
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
2 times, most recently
from
232cd85 to
fc35f87
Compare
Signed-off-by: Xie Zheng <[email protected]>
zhengxiexie
force-pushed
the
zhengxie/new_api_group
branch
from
fc35f87 to
c3be49c
Compare
dantingl
reviewed
Aug 2, 2024
dantingl
approved these changes
Aug 2, 2024
zhengxiexie
changed the title
|
/e2e |
1 similar comment
|
/e2e |
timdengyun
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since apiVersion
nsx.vmware.comconflicts with other teams, this patch supports the new apiVersion:crd.nsx.vmware.com.All vpc controllers will watch the new apiVersion, however, there is a special case, securitypolicy.
T1 mode securitypolicy has been released to the market, so we should check if the user is using T1, if yes, we should go on supporting it. The implementation behind it is to reuse the previous logic underlay,
convert.gois to converse the structs of the new and the old between, in the securitypolicy controller, we check whether to watch the old or the latest.On the NCP side, it will apply all the yamls in dir
build/yaml/crd, besides, since we will go on supporting T1 mode, we must check vpc FSS, if it is vpc mode, then also apply the yaml in dirbuild/yaml/crd/t1/, or in dirbuild/yaml/crd/vpc/.For VPC mode securitypolicy, it can be created successfully
So does T1 mode
New apiVersion also applies to other CRs.