Use the OCI Catalog when syncing charts. #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the sync code to also try the OCI Catalog service for app repositories where the repos aren't listed (after trying the VAC index).
Benefits
Finishes the work of #6263, although, as we've discussed, to benefit from this (ie. be able to add the public bitnami OCI repo), we need to add a couple more features, since currently it uses the existing OCI Distribution API which requires authentication. We'd like to ensure people don't need authentication to use a public OCI namespace, such as the bitnami catalog.
Possible drawbacks
Applicable issues
Additional information