Consistent log/error capitalization #6673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]> Conflicts: cmd/apprepository-controller/cmd/root.go
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
antgamdia
force-pushed
the
6672-consistent-log-error-case
branch
from
adec462 to
0e7b927
Compare
Signed-off-by: Antonio Gamez Diaz <[email protected]>
antgamdia
force-pushed
the
6672-consistent-log-error-case
branch
from
0e7b927 to
1742510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The log traces and the error messages have an inconsistent capitalization across the codebase; this PR is to fix it.
I have used some regexes like
fmt.(New|Debug|Warn||Warning|Info|Error|Fatal|Panic)(f?)(S?)\(("|')\p{Ll},connect\.\w+, fmt.(New|Debug|Warn||Warning|Info|Error|Fatal|Panic)(f?)(S?)\(("|')\p{Ll}to find any possible offending occurrence.The rationale behind the transformation is:
Benefits
Consistent capitalization.
Possible drawbacks
Some tests might fail, but will fix them straight away.
Applicable issues
Additional information
The next step would be unifying the actual messages, but this is another yak to shave...