Improve kubeapps-apis dockerfile and docs #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <[email protected]>
✅ Deploy Preview for kubeapps-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
absoludity
approved these changes
Aug 9, 2023
| RUN curl -sSL "https://github.com/bufbuild/buf/releases/download/v$BUF_VERSION/buf-Linux-x86_64" -o "/tmp/buf" && chmod +x "/tmp/buf" | ||
| RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v$GOLANGCILINT_VERSION | ||
|
|
||
| # TODO: Remove and instead use built-in gRPC container probes once we're supporting >= 1.24 only. https://kubernetes.io/blog/2022/05/13/grpc-probes-now-in-beta/ |
There was a problem hiding this comment.
Just noticed GKE_STABLE_VERSION is now 1.25, so we can remove this and update the chart too (not here).
There was a problem hiding this comment.
Yeah, we could potentially do it, but it can have some unintended side effects if we sync our chart with Bitnami's. AFAIK, there is still some k8s 1.23 testing in place :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Just a minor PR mainly sorting the
ARGs and adding some comments to make it easier to find the latest release. Also, making the download of golangci-lint conditional.Finally, adding
GRPC_HEALTH_PROBE_VERSIONto the docs, so that we can find it easily.Benefits
More clear dockerfile
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
N/A