Update yarn deps #6532
Merged
Update yarn deps #6532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <[email protected]>
|
Thanks Antonio. Note that the carrot ( |
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]> Conflicts: dashboard/package.json
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Signed-off-by: Antonio Gamez Diaz <[email protected]>
antgamdia
commented
Aug 3, 2023
Comment on lines
-112
to
-113
| // Note the U+200C, which is a zero-width non-joiner, character instead of a space | ||
| await expect(page.locator(".values-editor div.modified")).toContainText("tag:·2.4.48-debian-10-r75"); |
There was a problem hiding this comment.
We finally were able to remove the U+200C character and use a normal space instead thanks to this Monaco upgrade!
absoludity
approved these changes
Aug 4, 2023
Signed-off-by: Antonio Gamez Diaz <[email protected]> Conflicts: dashboard/package.json dashboard/yarn.lock
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR bumps some yarn dependencies up. However, plenty of them were already up-to-date thanks to the
^operator.I don't know why Dependabot is ignoring them... perhaps we closed a PR in the past?
Benefits
Up-to-date deps :P
Possible drawbacks
N/A - CI is passing now after a few tweaks in the monaco-related tests.
Edit: I'm having some issues with the e2e tests, just some minor changes in the selector, but I'm on it already. Hope to fix the pipeline soon.Applicable issues
N/A
Additional information
The remaining ones are the following, but they require extra work in order to get them to work.
Related to React Router v6
Related to React 18
Others