Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initially stubbed ocicatalog grpc service. #6282

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

absoludity
Copy link
Contributor

Description of the change

As per #6263, this PR adds an initally stubbed ocicatalog service gRPC service implementation.

Benefits

Can begin building the fully featured OCI Catalog for indexing OCI repositories.

Applicable issues

Additional information

$ grpcurl -proto ./proto/ocicatalog.proto -d '{"registry": "registry-1.docker.io"}' -plaintext "[::1]:50051" ocicatalog.OCICatalog.ListRepositoriesForRegistry
{
  "registry": "registry-1.docker.io",
  "name": "repo-0"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-1"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-2"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-3"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-4"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-5"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-6"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-7"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-8"
}
{
  "registry": "registry-1.docker.io",
  "name": "repo-9"
}

$ grpcurl -proto ./proto/ocicatalog.proto -d '{"repository": {"registry": "registry-1.docker.io"}}' -plaintext "[::1]:50051" ocicatalog.OCICatalog.ListTagsForRepository
{
  "name": "tag-0"
}
{
  "name": "tag-1"
}
{
  "name": "tag-2"
}
{
  "name": "tag-3"
}
{
  "name": "tag-4"
}
{
  "name": "tag-5"
}
{
  "name": "tag-6"
}
{
  "name": "tag-7"
}
{
  "name": "tag-8"
}
{
  "name": "tag-9"
}

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit ef0b497
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/647ec461d102da000800d815

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 1634 files.

Valid Invalid Ignored Fixed
805 2 827 0
Click to see the invalid file list
  • cmd/oci-catalog/Cargo.toml
  • cmd/oci-catalog/build.rs

@@ -0,0 +1,15 @@
[package]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[package]
# Copyright 2023 the Kubeapps contributors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
[package]

@@ -0,0 +1,4 @@
fn main() -> Result<(), Box<dyn std::error::Error>> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fn main() -> Result<(), Box<dyn std::error::Error>> {
// Copyright 2023 the Kubeapps contributors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
fn main() -> Result<(), Box<dyn std::error::Error>> {

Signed-off-by: Michael Nelson <[email protected]>
@absoludity absoludity merged commit c620d96 into main Jun 7, 2023
@absoludity absoludity deleted the 6179-investigation branch June 7, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants