Adds generation for buf connect gRPCWeb ts clients. #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Michael Nelson <[email protected]>
Signed-off-by: Michael Nelson <[email protected]>
Signed-off-by: Michael Nelson <[email protected]>
absoludity
force-pushed
the
use-buf-grpc-web
branch
from
d61f29f to
1b45e47
Compare
Ignore dashboard/src/gen when linting (for memory and not necessary) Signed-off-by: Michael Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one of a series for #6013
Description of the change
Adds support for the typescript clients used by buf connect's gRPC-Web.
Benefits
Just allows the next PR to be reviewable, only containing the actual code changes rather than the generated changes.
Possible drawbacks
Applicable issues
Additional information
Once we've switched over, we can also look at removing this generated code altogether, since the buf connect system has support for remote plugins, enabling simple imports of the remotely generated code.