Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more explicit error logging when fetching detail. #5895

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

absoludity
Copy link
Contributor

Signed-off-by: Michael Nelson [email protected]

Description of the change

A user is getting an error in the UX showing "Unable to retrieve chart: sql: no rows in result set" but no corresponding error in the backend. Checking, I found that we don't actually log the error, other than the request log showing the internal error without details:

I0119 19:05:27.529184       1 server.go:314] Requesting chart 'repo/kubeapps%2Fnginx' (latest version) in ns 'default'
I0119 19:05:27.530935       1 server.go:375] Requesting chart 'repo/kubeapps%2Fnginx' (latest version) in ns 'default'
I0119 19:05:27.535286       1 server.go:62] Internal 88.857512ms /kubeappsapis.core.packages.v1alpha1.PackagesService/GetAvailablePackageDetail
I0119 19:05:27.536622       1 server.go:62] Internal 90.361477ms /kubeappsapis.core.packages.v1alpha1.PackagesService/GetAvailablePackageVersions

With this change we'll have details about the actual error in the backend logs.

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 614f743
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63c9b5a1f75ca10009309851

@absoludity absoludity merged commit 1e8ee5c into vmware-tanzu:main Jan 20, 2023
@absoludity absoludity deleted the better-logging branch January 20, 2023 05:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants