-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for [Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871 #5714
fix for [Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871 #5714
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Dimitri please review when you get a chance. The changes should look pretty familiar to what you just did with helm plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code wise, i think there is no problem (just a few notes).
but can you check the change to the schema, this might be an issue.
moved secret management functionality into a separate file repo_auth.go