Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for [Repository] refactor fluxv2 to use managed-by annotation instead of system flag #4871 #5714

Merged
merged 16 commits into from
Nov 29, 2022

Conversation

gfichtenholt
Copy link
Contributor

@gfichtenholt gfichtenholt commented Nov 24, 2022

moved secret management functionality into a separate file repo_auth.go

@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5da6372
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63859bdcbcb8dd0008071ed9

@gfichtenholt
Copy link
Contributor Author

Dimitri please review when you get a chance. The changes should look pretty familiar to what you just did with helm plugin
Thanks

Copy link
Collaborator

@dlaloue-vmware dlaloue-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise, i think there is no problem (just a few notes).
but can you check the change to the schema, this might be an issue.

@gfichtenholt gfichtenholt merged commit ba97842 into vmware-tanzu:main Nov 29, 2022
@gfichtenholt gfichtenholt deleted the flux-incremental-4 branch November 29, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Repository] refactor fluxv2 to use managed-by annotation instead of system flag
3 participants