Fix GHA's release workflow #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <[email protected]>
beni0888
added
component/ci
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
antgamdia
approved these changes
Nov 22, 2022
absoludity
reviewed
Nov 22, 2022
| @@ -617,7 +617,7 @@ jobs: | |||
| sync_chart_from_bitnami: | |||
| needs: | |||
| - setup | |||
| if: needs.setup.outputs.running_on_main == 'true' | |||
| if: needs.setup.outputs.running_on_main == 'true' || needs.setup.outputs.running_on_tag == 'true' | |||
There was a problem hiding this comment.
I'm still not clear in my mind why we want to sync the bitnami chart each time a PR targets main? Wouldn't we only want to do so if there isn't a PR already open to sync the bitnami chart into our main? (given that the one PR can be recreated or just have latest changes merged etc?)
Thanks either way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada [email protected]
Description of the change
This commit fixes the GHA's Release Pipeline. Currently, the workflow is not working properly because the
sync_chart_from_bitnamionly runs when the pipeline is triggered from the main branch, and it should run when it's triggered from a version tag also.Benefits
The GHA's Release Pipeline works as expected.
Possible drawbacks
None
Applicable issues