Add some minor improvements in the GHA's kubeapps-general pipeline #5685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
beni0888
added
component/ci
Signed-off-by: Jesús Benito Calzada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada [email protected]
Description of the change
This commit adds just some minor improvements to the GHA's kubeapps-general workflow. The changes consist mainly of applying more restrictive bash options (
set -eu) so the scripts fail out loud when a required env var is not defined and finish their execution when an intermediate command returns a non-zero code.Benefits
We follow shell script's best practices to try to avoid subtle bugs.
Possible drawbacks
More restrictive bash options could result in breaking some currently running scripts, or even lead us to discover some unnoticed misbehaviors.
Applicable issues
Additional information
None