Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kubeapps favicon #287

Merged
merged 2 commits into from
May 1, 2018
Merged

add kubeapps favicon #287

merged 2 commits into from
May 1, 2018

Conversation

prydonius
Copy link
Contributor

fixes #160

@prydonius prydonius requested a review from Angelmmiguel April 30, 2018 17:09
@prydonius
Copy link
Contributor Author

cc @Angelmmiguel

Angelmmiguel
Angelmmiguel suggested changes May 1, 2018
View reviewed changes
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we can have at least the 128x128 and the 196x196 icons as high res favicons.

@prydonius
Copy link
Contributor Author

@Angelmmiguel ptal!

Angelmmiguel
Angelmmiguel approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks :)

@prydonius prydonius merged commit c35fba2 into vmware-tanzu:master May 1, 2018
@prydonius prydonius deleted the favicon branch May 1, 2018 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angelmmiguel Angelmmiguel Angelmmiguel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the favicon to the project
2 participants
@prydonius @Angelmmiguel