adds a guard to prevent overriding existing sealed-secrets installations #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sameersbn can I get 👀 on this? |
sameersbn
approved these changes
Mar 16, 2018
There was a problem hiding this comment.
lgtm! I think that message should be displayed as a warning and since the effects of inadvertently overriding the existing controller could be catastrophic, I suggest adding a double confirmation or at the least making the user type "yes" or "no".
WARNING: sealed-secrets exists and was not installed by Kubeapps, continuing could override and interfere with your existing sealed-secrets controller.
Continue? (y/n): y
Are you really sure? (yes/no):
|
@sameersbn applied your changes. r.e. the second prompt, I haven't changed the confirmPrompt function to actually only accept "yes" or "no" in the second case (it will still accept "y"), but the message does indicate "yes"/"no" which will hopefully direct most people to type it out. |
sameersbn
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Kubeapps installs sealed secrets in the kube-system namespace, if you already have it installed it can accidentally override this. This PR adds a prompt to the user to check if they really want to override sealed-secrets.