Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client-go to 4.0.0 or greater #40

Closed
prydonius opened this issue Nov 15, 2017 · 4 comments
Closed

Update client-go to 4.0.0 or greater #40

prydonius opened this issue Nov 15, 2017 · 4 comments

Comments

@prydonius
Copy link
Contributor

In order to use client-go to create a portforward connection, we need the remotecommand or spdy package. remotecommand moved to client-go in kubernetes/client-go@20e59c6#diff-8656ac6cd2859b6ba2961d35c31735b4 and previously this was in kubernetes/kubernetes. This is how kubectl implements portforward today
with the spdy package (https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/portforward.go#L102) and previously with remotecommand (https://github.com/kubernetes/kubernetes/blob/2612e0c78ad18ac87bbd200d547100cf99f36089/pkg/kubectl/cmd/portforward.go#L104).

So, in order to avoid adding kubernetes/kubernetes as a dependency here, we could upgrade client-go. The problem is that this pulls in a newer version of apimachinery which doesn't seem to be compatible with kubecfg. As usual, we're in Kubernetes dependency hell...

There might be another way to implement this, but I couldn't find any other documentation than what kubectl is doing.

For now, we can have the dashboard command execute kubectl port-forward, but ideally we're able to use the client-go library to create this portforward.

@prydonius prydonius changed the title Update client-go to 4.00 or greater Update client-go to 4.0.0 or greater Nov 15, 2017
@ngtuna
Copy link
Contributor

ngtuna commented Nov 15, 2017

I might be missing things today (too busy trying to understand gcloud cli :-( ), but what do you intend to do with portforward connection in installer ?

@prydonius
Copy link
Contributor Author

@ngtuna sorry, it's for the dashboard command which will setup a port-forward with the nginx controller pod. See #41

@ngtuna
Copy link
Contributor

ngtuna commented Nov 29, 2017

Ref #65

@ngtuna
Copy link
Contributor

ngtuna commented Nov 30, 2017

closed via #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants