Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiller release gets updated twice when migrating to Kubeapps #345

Closed
prydonius opened this issue Jun 6, 2018 · 2 comments
Closed

Tiller release gets updated twice when migrating to Kubeapps #345

prydonius opened this issue Jun 6, 2018 · 2 comments
Labels
kind/bug An issue that reports a defect in an existing feature

Comments

@prydonius
Copy link
Contributor

In #330, I discovered that migrating a release results in the Tiller release getting updated twice. It should only be updated once.

Steps to reproduce:

  1. Checkout code from Add support for viewing and migrate Tiller releases #330
  2. Create a Helm release using the CLI helm --tiller-namespace=kubeapps install stable/redis
  3. Migrate it in Kubeapps
  4. Notice that the Helm release is now at revision 3 helm --tiller-namespace=kubeapps list

This might actually be an issue during upgrade also, I haven't verified this.

@prydonius prydonius added kind/bug An issue that reports a defect in an existing feature priority/backlog labels Jun 6, 2018
@andresmgot
Copy link
Contributor

I am not sure if this is an issue. It is true that the revision gets bumped but if there are no changes the deployment won't be updated. This is the same behavior than when you execute helm upgrade ... several times.

@andresmgot
Copy link
Contributor

Ah, sorry I misunderstood it. That's an issue yes. It's caused because the controller modifies the HelmRelease metadata to add a finalizer and that gets interpreted as an upgrade. This PR: vmware-archive/helm-crd#31 should fix that.

andresmgot pushed a commit that referenced this issue Jun 8, 2018
andresmgot added a commit that referenced this issue Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug An issue that reports a defect in an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants