Removing httpclient.Client interface. (#6746)

### Description of the change Part 1 removing the httpclient.Client interface. See #6726 for which this is needed. ### Benefits Able to write code that expects a plain http.Client. Better tests. ### Possible drawbacks ### Applicable issues - ref #6726 ### Additional information --------- Signed-off-by: Michael Nelson <[email protected]>
vmware-tanzu · Sep 1, 2023 · 9782c44 · 9782c44
1 parent 95b6f6f
commit 9782c44
Show file tree

Hide file tree

Showing 13 changed files with 368 additions and 435 deletions.
diff --git a/cmd/asset-syncer/server/utils.go b/cmd/asset-syncer/server/utils.go
@@ -136,7 +136,7 @@ type ChartCatalog interface {
 type HelmRepo struct {
 	content []byte
 	*models.AppRepositoryInternal
-	netClient httpclient.Client
+	netClient *http.Client
 	filter    *apprepov1alpha1.FilterRuleSpec
 }
 
@@ -781,7 +781,7 @@ func parseFilters(filters string) (*apprepov1alpha1.FilterRuleSpec, error) {
 	return filterSpec, nil
 }
 
-func getHelmRepo(namespace, name, repoURL, authorizationHeader string, filter *apprepov1alpha1.FilterRuleSpec, netClient httpclient.Client, userAgent string) (ChartCatalog, error) {
+func getHelmRepo(namespace, name, repoURL, authorizationHeader string, filter *apprepov1alpha1.FilterRuleSpec, netClient *http.Client, userAgent string) (ChartCatalog, error) {
 	url, err := parseRepoURL(repoURL)
 	if err != nil {
 		log.Errorf("Failed to parse URL, url=%s: %v", repoURL, err)