Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo err #619

Merged
merged 1 commit into from
Jun 24, 2022
Merged

fix typo err #619

merged 1 commit into from
Jun 24, 2022

Conversation

ruifaling
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # 618

Additional information
This is just a minor typo err about bootstrapKubeconfigDataStr

Special notes for your reviewer

@vmwclabot
Copy link

@ruifaling, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #619 (1e973dc) into main (49a9cdb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files          19       19           
  Lines        1964     1964           
=======================================
  Hits         1355     1355           
  Misses        497      497           
  Partials      112      112           
Impacted Files Coverage Δ
...s/infrastructure/bootstrapkubeconfig_controller.go 58.49% <100.00%> (ø)

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@anusha94
Copy link
Contributor

@ruifaling Please sign the CLA

@ruifaling
Copy link
Contributor Author

@shubham14bajpai @anusha94 ,thanks for your review! And I have signed the CLA,is there anything other I can do?This is my first pr about this project. I will be very happy to receive your guidance.

@shamsher31 shamsher31 merged commit 90de592 into vmware-tanzu:main Jun 24, 2022
@vmwclabot
Copy link

@ruifaling, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

@vmwclabot
Copy link

@ruifaling, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

1 similar comment
@vmwclabot
Copy link

@ruifaling, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants