Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYOH agent documentation #611

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

Madhur97
Copy link
Contributor

@Madhur97 Madhur97 commented Jun 22, 2022

What this PR does / why we need it:
This PR adds BYO host agent documentation in docs. This will be used to add all agent related information.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #622

Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful doc!
Minor nits - otherwise lgtm

docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
@anusha94
Copy link
Contributor

@Madhur97 Your CLA is not verified. Since you are a VMware employee, you can be a member of the vmware-tanzu org. Ping the team for help on this.

docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022

Codecov Report

Merging #611 (8f9b359) into main (45d0b6a) will increase coverage by 1.23%.
The diff coverage is n/a.

❗ Current head 8f9b359 differs from pull request most recent head 2510a5a. Consider uploading reports for the commit 2510a5a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   67.75%   68.99%   +1.23%     
==========================================
  Files          26       19       -7     
  Lines        2388     1964     -424     
==========================================
- Hits         1618     1355     -263     
+ Misses        662      497     -165     
- Partials      108      112       +4     
Impacted Files Coverage Δ
.../installer/internal/algo/output_builder_counter.go
agent/installer/os_detector.go
agent/installer/registry.go
agent/installer/internal/algo/apt_step.go
agent/installer/internal/algo/shell_step.go
.../installer/internal/algo/mock_ubuntu_with_error.go
agent/installer/checks.go
agent/installer/installer.go
agent/installer/internal/algo/ubuntu20_4K8s1_22.go
agent/installer/internal/algo/installer.go
... and 11 more

shamsher31
shamsher31 previously approved these changes Jun 24, 2022
Copy link
Contributor

@shamsher31 shamsher31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and as @anusha94 mentioned this is very useful.

docs/byoh_agent.md Outdated Show resolved Hide resolved
docs/byoh_agent.md Outdated Show resolved Hide resolved
@anusha94 anusha94 merged commit 1edf2d7 into vmware-tanzu:main Jun 24, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Add documentation for BYOH agent
6 participants