-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BYOH agent documentation #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super useful doc!
Minor nits - otherwise lgtm
@Madhur97 Your CLA is not verified. Since you are a VMware employee, you can be a member of the |
f39efd9
to
8f9b359
Compare
8f9b359
to
d1a285e
Compare
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 67.75% 68.99% +1.23%
==========================================
Files 26 19 -7
Lines 2388 1964 -424
==========================================
- Hits 1618 1355 -263
+ Misses 662 497 -165
- Partials 108 112 +4 |
d1a285e
to
2510a5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and as @anusha94 mentioned this is very useful.
2510a5a
to
cb6af4e
Compare
What this PR does / why we need it:
This PR adds BYO host agent documentation in docs. This will be used to add all agent related information.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #622