Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubebuilder markers for RBACs for CSR #590

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Add kubebuilder markers for RBACs for CSR #590

merged 1 commit into from
Jun 13, 2022

Conversation

dharmjit
Copy link
Contributor

What this PR does / why we need it:
The make manifests target is updating the RBAC file role.yaml as the appropriate kubebuilder markers are not present.

Which issue(s) this PR fixes:
Fixes #

anusha94
anusha94 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shivi28
Copy link
Contributor

shivi28 commented Jun 13, 2022

Do we need only update permission for certificatesigningrequests/approval ? I referred this PR, here we have other permissions also for above resource.

@shivi28
Copy link
Contributor

shivi28 commented Jun 13, 2022

lgtm

@shivi28
Copy link
Contributor

shivi28 commented Jun 13, 2022

Do we need only update permission for certificatesigningrequests/approval ? I referred this PR, here we have other permissions also for above resource.

@dharmjit mentioned only update is needed for our use case and verified it with local e2e testing.

shubham14bajpai
shubham14bajpai approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dharmjit dharmjit merged commit 8857aba into vmware-tanzu:main Jun 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anusha94 anusha94 anusha94 approved these changes

@shubham14bajpai shubham14bajpai shubham14bajpai approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dharmjit @shivi28 @anusha94 @shubham14bajpai @vmwclabot