Fix agent to mark conditions with appropriate status on uninstall #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 67.46% 67.83% +0.36%
==========================================
Files 27 27
Lines 2410 2400 -10
==========================================
+ Hits 1626 1628 +2
+ Misses 676 664 -12
Partials 108 108
|
anusha94
reviewed
Jun 10, 2022
shamsher31
reviewed
Jun 15, 2022
shamsher31
previously approved these changes
Jun 15, 2022
shubham14bajpai
dismissed stale reviews from shamsher31, anusha94, and khannakshat7
via
75158a8
shubham14bajpai
force-pushed
the
installer-condition
branch
from
6118454
to
75158a8
Compare
Signed-off-by: Shubham <[email protected]>
shubham14bajpai
force-pushed
the
installer-condition
branch
from
75158a8
to
deb771e
Compare
anusha94
approved these changes
Jun 21, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham [email protected]
What this PR does / why we need it:
This PR marks the K8sComponentsInstallationSucceeded condition as false whenever a host a removed from the cluster and the uninstall is executed successfully. It also fixes an existing test by asserting the correct condition for it's status.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #585
Additional information
Special notes for your reviewer