-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ByoClusterTemplate added for cluster class support #540
Conversation
@shivi28, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed. |
Requesting @dharmjit to kindly review this |
Codecov Report
@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 63.63% 63.67% +0.03%
==========================================
Files 25 26 +1
Lines 1936 1938 +2
==========================================
+ Hits 1232 1234 +2
Misses 625 625
Partials 79 79
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no need for any observed state for ByoClusterTemplate
i.e a ByoClusterTemplateStatus
for cluster class?
Right now there is no benefit of having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #536
Additional information
Special notes for your reviewer