-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8sInstallerConfig controller implementation added #526
K8sInstallerConfig controller implementation added #526
Conversation
ca09f8f
to
7a4cfe4
Compare
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 63.67% 65.22% +1.55%
==========================================
Files 26 27 +1
Lines 1938 2151 +213
==========================================
+ Hits 1234 1403 +169
- Misses 625 657 +32
- Partials 79 91 +12
|
eea1a08
to
470dbfe
Compare
470dbfe
to
d48ed6c
Compare
@mayur-tolexo, This PR is missing tests for |
@dharmjit , Sorry, I didn't get it. Which test case is missing? |
d199911
to
bbb92f2
Compare
Oh my bad, somehow I missed - k8sinstallerconfig_controller_test.go |
0cfbfc5
to
7c1631f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
controllers/infrastructure/k8sinstallerconfig_controller_test.go
Outdated
Show resolved
Hide resolved
K8sInstallerConfig controller will be generation the installation secret for the bundleType to install on byohost test cases added To increase the test coverage, few test cases added for k8sinstallercontroller - should not return reconcile request if ByoMachine InstallerRef doesn't exists - should not return reconcile request if ByoMachine InstallerRef doesn't refer to K8sInstallerConfitTemplate - should return reconcile request if ByoMachine refer to K8sInstallerConfigTemplate installer Signed-off-by: Mayur Das <[email protected]>
7c1631f
to
cf876ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
K8sInstallerConfig controller will be generation the installation secret
for the bundleType to install on byohost
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #517
Additional information for reviewer
Normal Reconcile flow
status.ready
is true, exit the reconcilaitoninstall
(string): contains installation bash scriptuninstall
(string): contains uninstallation bash script{{.BundleDownloadPath}}
: path on host where bundle will be downloaded by byoh agentstatus.installationSecret
to the generated secret object referencestatus.ready = true
Delete Reconcile flow
status.installationSecret
reference