Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New K8sInstallerConfig CRD created #490

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

mayur-tolexo
Copy link
Contributor

@mayur-tolexo mayur-tolexo commented Apr 19, 2022

What this PR does / why we need it:
Created new API K8sInstallerConfig and added the K8sInstallerConfig CRD spec and status

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #489 (partially)

Additional information
Added following data types in K8sInstallerConfig CRD

  • spec field with the following:
    • BundleRepo (string): Registry from which bundle will be downloaded
    • BundleType (string): type of the bundle (e.g. vanilla-k8s, k3s) need to be downloaded
  • status field with the following:
    • Ready (boolean): indicates the installation secret has been generated and is ready
    • InstallationSecret (ObjectReference): installation secret object reference

anusha94
anusha94 previously approved these changes Apr 19, 2022
Copy link
Contributor

@anusha94 anusha94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dharmjit dharmjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some minor nits only.

@mayur-tolexo mayur-tolexo force-pushed the api-k8sinstallerconfig-crd branch 2 times, most recently from d344453 to abff9ed Compare April 20, 2022 05:58
Created new API K8sInstallerConfig and added the K8sInstallerConfig crd specs and status

Signed-off-by: Mayur Das <[email protected]>
@shamsher31
Copy link
Contributor

/lgtm

@dharmjit dharmjit merged commit 3023144 into vmware-tanzu:main Apr 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new API of kind K8sInstallerConfig
5 participants