-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New K8sInstallerConfig CRD created #490
Merged
dharmjit
merged 1 commit into
vmware-tanzu:main
from
mayur-tolexo:api-k8sinstallerconfig-crd
Apr 26, 2022
Merged
New K8sInstallerConfig CRD created #490
dharmjit
merged 1 commit into
vmware-tanzu:main
from
mayur-tolexo:api-k8sinstallerconfig-crd
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha94
reviewed
Apr 19, 2022
mayur-tolexo
force-pushed
the
api-k8sinstallerconfig-crd
branch
from
April 19, 2022 15:35
026b4e2
to
7dcf925
Compare
anusha94
previously approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mayur-tolexo
force-pushed
the
api-k8sinstallerconfig-crd
branch
from
April 19, 2022 15:38
7dcf925
to
9a148fb
Compare
dharmjit
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some minor nits only.
mayur-tolexo
force-pushed
the
api-k8sinstallerconfig-crd
branch
2 times, most recently
from
April 20, 2022 05:58
d344453
to
abff9ed
Compare
Created new API K8sInstallerConfig and added the K8sInstallerConfig crd specs and status Signed-off-by: Mayur Das <[email protected]>
mayur-tolexo
force-pushed
the
api-k8sinstallerconfig-crd
branch
from
April 20, 2022 06:19
abff9ed
to
d38f39c
Compare
shamsher31
reviewed
Apr 20, 2022
/lgtm |
shamsher31
approved these changes
Apr 20, 2022
shamsher31
reviewed
Apr 20, 2022
dharmjit
approved these changes
Apr 21, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Created new API K8sInstallerConfig and added the K8sInstallerConfig CRD
spec
andstatus
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #489 (partially)
Additional information
Added following data types in
K8sInstallerConfig
CRD