Installer OS mapping #207
Installer OS mapping #207
Conversation
A BYOH bundle and installer Algo are developed and tested using a specific OS version (including patch version). This is why the patch version is included in the BYOH bundle name. An old BYOH Bundle may work with newer OS patches and versions. This PR make the installer smart. It can map any OS version to any BYOH Bundle and installer Algo. Example: A BYOH Bundle and installer Algo are created for Ubuntu_20.04.1_x86-64. They will also be used on all Ubuntu 20.04 patches. OS K8S Version BYOH Bundle Name --- ----------- ---------------- Ubuntu_20.04.1_x86-64 v1.22.1 byoh-bundle-ubuntu_20.04.1_x86-64_k8s_v1.22.1 Ubuntu_20.04.*_x86-64 v1.22.1 byoh-bundle-ubuntu_20.04.1_x86-64_k8s_v1.22.1
ratanasovvmw
requested review from
jamiemonserrate,
dharmjit,
yixingjia,
jeuxdemains,
anusha94 and
georgievaVMW
1. Entries associating BYOH Bundle in the Repository with Installer in Host Agent 2. Entries that match an OS to a BYOH Bundle OS in the Repository cli --list-supported OS K8S Version BYOH Bundle Name --- ----------- ---------------- Ubuntu_20.04.*_x86-64 v1.22.1 byoh-bundle-ubuntu_20.04.1_x86-64_k8s_v1.22.1
| OutputBuilder: ob} | ||
| reg.Add(t.os, t.k8s, a) | ||
| // Match concrete os version to repository os version | ||
| reg.AddOsFilter("Ubuntu_20.04.*_x86-64", linuxDistro) |
There was a problem hiding this comment.
Question - do we need to hard code this? Can this be injected/overridden via a config file? This could help in our integration testing too.
There was a problem hiding this comment.
It can be made configurable when needed.
Technically speaking
- only the "Ubuntu_20.04.*_x86-64" can be configurable
- the "Ubuntu_20.04.1_x86-64" cannot be configurable because it is bound to a struct which may be different for OSes and versions. It is the core of the installer
Workflow speaking,
- yixingjia implies that this lib is the source of truth and needs to be queried
- if it is configurable whose responsibility would be to do that?
Testing speaking,
- my experience so far is that we need to override the detection of the current OS. E.g. if lib has ubuntu2004 and I'm running on ubuntu1804, I can override and treat it as ubuntu2004
- I suggest to make configurable when we have a concrete use-case
There was a problem hiding this comment.
Had a meeting with Dharmjit and Yixing where config files were also mentioned but regarding that downstream version for k8s is 1.2.1+vmware.1. Some component needs to be able to understand upstream and downstream k8s versions like (1.2.1+vmware.1). Such component can be a config file (which is similar to fork)
Agreed we need to look at this holistically post FC.
| ) | ||
|
|
||
| var ( | ||
| listSupportedFlag = flag.Bool("list-supported", false, "List all supported OS and Kubernetes versions") | ||
| listBundlesFlag = flag.Bool("list-bundles", false, "List the BYOH Bundle names for all supported OS and Kubernetes versions") | ||
| listSupportedFlag = flag.Bool("list-supported", false, "List all supported OS, Kubernetes versions and BYOH Bundle names") |
There was a problem hiding this comment.
Just a question, maybe I'm wrong :)
Should we add the list support bundles function in the management cluster side?
If I'm an end user, after I install the byoh provider , then I will expect to check what bundles do we have in the repo on the management cluster side instead of login to the remote byoh host.
Then I can decide which version of kubernest/ bundle I would like to use to create the cluster on byoh host.
There was a problem hiding this comment.
Makes sense. This is just a CLI of the installer lib that is used by the host agent. So, the CP can retrieve the same info by the lib directly. The exact workflow for that is outside installer lib charter.
There was a problem hiding this comment.
Changes look good for now, But as @ratanasovvmw mentioned we need to look at it again from the UX perspective.
A BYOH bundle and installer Algo are developed and tested using a specific OS version (including patch version).
This is why the patch version is included in the BYOH bundle name. An old BYOH Bundle may work with newer OS patches and versions.
This PR make the installer smart. It can map any OS version to any BYOH Bundle and installer Algo.
Registry contains
cli --list-supported
Testing done
On a Ubuntu 18.04
./cli --list-supported
./cli --preview-os-changes --os Ubuntu_20.04.*_x86-64 --k8s v1.22.1
./cli --install --os Ubuntu_20.04.1_x86-64 --k8s v1.22.1 --bundle-repo
./cli --uninstall --os Ubuntu_20.04.1_x86-64 --k8s v1.22.1 --bundle-repo