clean the /et/cni/net.d folder before we start the k8s provsion #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Signed-off-by: Hui Chen <[email protected]>
huchen2021
requested review from
jamiemonserrate,
yixingjia,
lwmqwer,
anusha94 and
dharmjit
dharmjit
reviewed
Oct 29, 2021
Signed-off-by: Hui Chen <[email protected]>
dharmjit
previously approved these changes
Nov 1, 2021
Co-authored-by: Dharmjit Singh <[email protected]>
Co-authored-by: Dharmjit Singh <[email protected]>
dharmjit
previously approved these changes
Nov 1, 2021
Signed-off-by: Hui Chen <[email protected]>
huchen2021
added
the
do-not-merge/work-in-progress
added 2 commits
November 1, 2021 15:01
Signed-off-by: Hui Chen <[email protected]>
…b runner, and caused failure of test-agent case Signed-off-by: Hui Chen <[email protected]>
huchen2021
removed
the
do-not-merge/work-in-progress
…2e case failed. Only clean all the files or directories under /etc/cni/net.d directory Signed-off-by: Hui Chen <[email protected]>
anusha94
reviewed
Nov 2, 2021
Signed-off-by: Hui Chen <[email protected]>
It's hard to test this in unit tests. All I call is system function, let's have some confidence about it. |
dharmjit
reviewed
Nov 2, 2021
dharmjit
approved these changes
Nov 2, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should clean the /et/cni/net.d folder before we start the k8s provsion. It will save us from a lot of potential network issues, especially we try to re-use a byoh host.