Use require_relative instead of require to speed up requires #175
Conversation
require_relative is faster as it doesn't require traversing the filesystem looking for the require. See benchmarks here: rspec/rspec-expectations#476 (comment) Signed-off-by: Tim Smith <[email protected]>
|
I'd love to merge this, but unfortunately the library currently still supports Ruby 1.8.7. I'm going to leave this open because I plan to drop support for all non-stable Ruby versions. Once I do that, I'll merge this in. I'm not sure when I'll have the time to do it, but I'd love to do that soon. |
|
Ruby 1.8.7 was dropped in #178 |
|
Only the CI support was dropped. Support for 1.8.7 is still in the library itself https://github.com/vmware/rbvmomi/blob/master/rbvmomi.gemspec#L32 |
|
@jrgarcia any update on dropping Ruby 1.8.7 support? |
|
I'll plan on doing this today. |
|
Thanks @jrgarcia |
|
No problem! Sorry it took so long! I'm changing a couple more things and then I'll push out a new major Gem release. |
|
Thanks so much for this! Just pushed rbvmomi v3 to RubyGems with these changes. |
require_relative is faster as it doesn't require traversing the
filesystem looking for the require.
See benchmarks here: rspec/rspec-expectations#476 (comment)
Signed-off-by: Tim Smith [email protected]