Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Edge: Update minimum Ha DeadTime limit #516

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

alagoutte
Copy link
Contributor

@alagoutte alagoutte commented May 14, 2018

it is now 3 secs (before 6secs)

Fix issue #513

it is now 3 secs (before 6secs)

Fix issue vmware-archive#513
@dcoghlan
Copy link
Contributor

Hey @alagoutte, If you can write some tests for this, it looks like a fairly easy one to merge.

@dcoghlan dcoghlan added the Test Required Tests are required before this request will be merged. label Jun 17, 2018
@alagoutte
Copy link
Contributor Author

Hi Dane,

it is a small change...
What test do you want ?

@nmbradford
Copy link
Contributor

Just a simple 'can I set it' and 'When I set it, does the returned object have it set as I asked' style tests. Just the two is fine.

@alagoutte
Copy link
Contributor Author

It is a quick fix...

and there is no test for the moment for HA...
And need to create a new Edge (you don't modified a setting from a Edge...)

@nmbradford
Copy link
Contributor

You can just included it in the existing edge tests.

@alagoutte
Copy link
Contributor Author

No found test with HA...

@nmbradford
Copy link
Contributor

You will note I didn't claim there was. Just create a single test for this in the existing edge tests.

@alagoutte
Copy link
Contributor Author

Adding a HA Tests

Can you launch test suite ?

@dcoghlan
Copy link
Contributor

jenkins test this please

@powernsxbot
Copy link

Tests Failed

@dcoghlan
Copy link
Contributor

jenkins test this please

@powernsxbot
Copy link

Tests Failed

@dcoghlan
Copy link
Contributor

jenkins test this please

@powernsxbot
Copy link

Tests Failed

@dcoghlan
Copy link
Contributor

jenkins test this please

@powernsxbot
Copy link

Tests Failed

@dcoghlan
Copy link
Contributor

Tests failed due to testing harness failures. Your changes passed successfully.

@dcoghlan dcoghlan merged commit 2bae037 into vmware-archive:master Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Test Required Tests are required before this request will be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants