fix: make sure nics are enable #43
Conversation
jfroche
force-pushed
the
fix/enable-nics
branch
from
ac1f8af
to
47aa677
Compare
cloud-init >= 20.3, subp is a seperate module. So, data source should be modified accordingly. If someoone is using guestinfo data source with cloud-init <=20.2 we should not break things. See the below link for more details: canonical/cloud-init@3c551f6 This patch takes care of the above things. Tested on Photon 3.0 VM with Photon OS using package test scripts. Signed-off-by: Shreenidhi Shedi <[email protected]>
Made minor code improvements in getting subp module Signed-off-by: Shreenidhi Shedi <[email protected]>
New machines created from a template sometimes don't have its network interfaces connected to the network. This happen for example when terraform customize the template after cloning. To fix this issue, we do the same as DataSourceOVF[1] and make sure that the interfaces defined by vmware-imc connect using vmware-rpctool. similar issue: vmware/open-vm-tools#299 [1]: https://github.com/canonical/cloud-init/blob/master/cloudinit/sources/DataSourceOVF.py#L261
jfroche
force-pushed
the
fix/enable-nics
branch
from
6c9d45c
to
b099462
Compare
|
Why is this not merged? |
Because it:
|
|
Where was this partially solved elsewhere? |
|
If you are interested in seeing this merged and would like to open a PR with this, addressing the above issues, please do so, and I will review in the morning (it's just past midnight here). |
|
Thanks will do! I'm still trying to figure out and understand why when I Terraform up some vSphere virtual machines resources from a template with customisations the NC(s) are left in a "disconnected" state. This only seems to happen when If it turns out this PR is still needed, I'll happily clean it up and re-submit a PR based off this work. |
|
This issue is being closed because this datasource has been merged into cloud-init (canonical/cloud-init#953):
In order to participate in the growth of this datasource moving forward, please:
Once again, many thanks to the wonderful community that has grown around this datasource, and I look forward to seeing everyone in the new cloud-init forums! |
New machines created from a template sometimes don't have its network
interfaces connected to the network. This happen for example when
terraform customize the template after cloning.
To fix this issue, we do the same as DataSourceOVF1 and make sure that
the interfaces defined by vmware-imc connect using vmware-rpctool.
similar issue: vmware/open-vm-tools#299