This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Support for pihole running in a podman container #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmstan
approved these changes
Feb 4, 2021
vmstan
added a commit
that referenced
this pull request
Feb 9, 2021
* Catch up 3.3 (#142) * 3.2.5 (#140) Co-authored-by: Michael Stanclift <[email protected]> * Adds backup cleanup back to process * Add backup cleanup to compare script when no changes are detected. * Trek reference * Redundant * 3.2.6 * 3.2.6 Co-authored-by: Michael Stanclift <[email protected]> Co-authored-by: Michael Stanclift <[email protected]> * Beginning 3.3.0 work * Podman support * Support for pihole running in a podman container (#138) * add support for pihole running in a podman container * revert renaming of DOCKER_CON to CON_NAME to avoid breaking existing installations Co-authored-by: Michael Stanclift <[email protected]> * Add sudo to call of Pihole container version * Use dev branch pipe * Without origin * ascii * rotate logo * Move config files to settings folder * MIssed an important one * Relocate logs files * Filling empty directory * Regression of sudo fix * Logs * More words * Change sync frequency options * Remove backup automation * Bold questions * name * elif * BACKUP_RETAIN=3 * Remove automation flag * == not != * Rearrange * IF * Default to 0 * 15 default * More words! * ELSE * tighter columns * Instance type * Y/N Co-authored-by: Michael Stanclift <[email protected]> Co-authored-by: Michael Stanclift <[email protected]> Co-authored-by: Martin F. Schumann <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for pihole instances running in podman (instead of docker) containers.
Changes visible to the user
Let me know what you think.