Fix problem with path relativize double URI escaping items like spaces #183
+46
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Selenium 2.49.0
to break when the file name contains spaces.
|
Thanks your PR! |
|
No problem. Thanks for your very useful tool. On 30 Jan 2016 12:34, "Motonori IWAMURO" <[email protected]
Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some tests with spaces in the filenames (e.g. test name) which were coming out in the screenshot links broken as
test%2520name
I believe the issue is that relativize is URI escaping the paths in order to compare them, but then the relativize function was doing a final URI escape on the URI escaped path.
The fix in this patch is to remove the extra escape.
Sorry about the CRLF conversion in the patch - I thought I had set it up to commit with LF only, but it seems to show all diffs as full file diffs. Feel free to simply apply the fix locally, if it looks good.