Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3/N] model runner pass the whole config to model #9958

Merged
merged 6 commits into from
Nov 2, 2024
Merged

[3/N] model runner pass the whole config to model #9958

merged 6 commits into from
Nov 2, 2024

Conversation

youkaichao
Copy link
Member

continue of #9938

@youkaichao
model runner to load model
96f3ac1 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
_initialize_model
9ba653e 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
loader
f132dbf 
Signed-off-by: youkaichao <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
fix args
8f2f2b0 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
use plugin
c5e76f5 
Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao marked this pull request as ready for review November 2, 2024 18:01
@youkaichao
fix circular import
67fb3f6 
Signed-off-by: youkaichao <[email protected]>
robertgshaw2-neuralmagic
robertgshaw2-neuralmagic approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can update line 35-47 of vllm/v1/worker/gpu_model_runner.py to remove all the members since now the vllm_config is piped down.

Otherwise LGTM

@youkaichao
Copy link
Member Author

I think you can update line 35-47 of vllm/v1/worker/gpu_model_runner.py to remove all the members since now the vllm_config is piped down.

@robertgshaw2-neuralmagic that seems unrelated to this pr. I'm not familiar with the v1 code path, and will leave it for who is familiar with the v1 code.

@youkaichao youkaichao merged commit cea808f into vllm-project:main Nov 2, 2024
29 of 31 checks passed
@youkaichao youkaichao deleted the runner_model branch November 2, 2024 19:08
This was referenced Nov 2, 2024
Merged
Merged
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@youkaichao
[3/N] model runner pass the whole config to model (vllm-project#9958)
628409d 
Signed-off-by: youkaichao <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@youkaichao
[3/N] model runner pass the whole config to model (vllm-project#9958)
94eb44a 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Nov 4, 2024
@youkaichao @richardsliu
[3/N] model runner pass the whole config to model (vllm-project#9958)
1dcbf25 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Nov 5, 2024
@youkaichao @bigPYJ1151
[3/N] model runner pass the whole config to model (vllm-project#9958)
1d32947 
Signed-off-by: youkaichao <[email protected]>
DarkLight1337 pushed a commit that referenced this pull request Nov 5, 2024
@youkaichao @DarkLight1337
[3/N] model runner pass the whole config to model (#9958)
aec095c 
Signed-off-by: youkaichao <[email protected]>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@youkaichao @hissu-hyvarinen
[3/N] model runner pass the whole config to model (vllm-project#9958)
8a0b21d 
Signed-off-by: youkaichao <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@youkaichao @JC1DA
[3/N] model runner pass the whole config to model (vllm-project#9958)
fa0826d 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@youkaichao @sumitd2
[3/N] model runner pass the whole config to model (vllm-project#9958)
eee723d 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@youkaichao
[3/N] model runner pass the whole config to model (vllm-project#9958)
643c159 
Signed-off-by: youkaichao <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@youkaichao @mfournioux
[3/N] model runner pass the whole config to model (vllm-project#9958)
7d77b59 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic robertgshaw2-neuralmagic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youkaichao @robertgshaw2-neuralmagic