Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch.compile] fix cpu broken code #9947

Merged
merged 1 commit into from
Nov 2, 2024
Merged

[torch.compile] fix cpu broken code #9947

merged 1 commit into from
Nov 2, 2024

Conversation

youkaichao
Copy link
Member

broken by #9896

@youkaichao
fix cpu code
a0648a2 
Signed-off-by: youkaichao <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 2, 2024
@youkaichao
Copy link
Member Author

error found in https://buildkite.com/vllm/ci-aws/builds/10628#0192eb5f-0793-43e6-bf18-9dd9b3ede594

@youkaichao youkaichao merged commit af7380d into vllm-project:main Nov 2, 2024
27 of 50 checks passed
@youkaichao youkaichao deleted the fix_cpu branch November 2, 2024 06:35
DarkLight1337 pushed a commit that referenced this pull request Nov 2, 2024
@youkaichao @DarkLight1337
[torch.compile] fix cpu broken code (#9947)
2062ff8 
Signed-off-by: youkaichao <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@youkaichao
[torch.compile] fix cpu broken code (vllm-project#9947)
b224334 
Signed-off-by: youkaichao <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@youkaichao
[torch.compile] fix cpu broken code (vllm-project#9947)
1e07489 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Nov 4, 2024
@youkaichao @richardsliu
[torch.compile] fix cpu broken code (vllm-project#9947)
b9d1578 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Nov 5, 2024
@youkaichao @bigPYJ1151
[torch.compile] fix cpu broken code (vllm-project#9947)
0ee2a07 
Signed-off-by: youkaichao <[email protected]>
DarkLight1337 pushed a commit that referenced this pull request Nov 5, 2024
@youkaichao @DarkLight1337
[torch.compile] fix cpu broken code (#9947)
1a04e7b 
Signed-off-by: youkaichao <[email protected]>
DarkLight1337 pushed a commit that referenced this pull request Nov 5, 2024
@youkaichao @DarkLight1337
[torch.compile] fix cpu broken code (#9947)
284055f 
Signed-off-by: youkaichao <[email protected]>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@youkaichao @hissu-hyvarinen
[torch.compile] fix cpu broken code (vllm-project#9947)
bf9f72c 
Signed-off-by: youkaichao <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@youkaichao @JC1DA
[torch.compile] fix cpu broken code (vllm-project#9947)
959cac0 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@youkaichao @sumitd2
[torch.compile] fix cpu broken code (vllm-project#9947)
083a4bc 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@youkaichao
[torch.compile] fix cpu broken code (vllm-project#9947)
874b5ce 
Signed-off-by: youkaichao <[email protected]>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@youkaichao @mfournioux
[torch.compile] fix cpu broken code (vllm-project#9947)
1bd1545 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youkaichao