[V1] Support per-request seed #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make batch generators sparse Signed-off-by: Nick Hill <[email protected]>
njhill
commented
Nov 2, 2024
| @@ -645,8 +650,7 @@ def make_sampling_metadata( | |||
| top_k=self.top_k[:self.num_reqs], | |||
| no_top_p=self.no_top_p, | |||
| no_top_k=self.no_top_k, | |||
| generators=self.generators[:self.num_reqs], | |||
| no_generator=self.no_generator, | |||
| generators=self.generators, | |||
| max_num_logprobs=self.max_num_logprobs, | |||
| ) | |||
There was a problem hiding this comment.
@WoosukKwon can we avoid re-creating the SamplingMetadata object here in the case skip_copy is True? Just keep it as a field in the batch ...
There was a problem hiding this comment.
Yeah that could be a great idea, though I think the current code doesn't hurt performance since only one sampling metadata is created for the entire batch.
WoosukKwon
approved these changes
Nov 3, 2024
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Nick Hill <[email protected]>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
richardsliu
pushed a commit
to richardsliu/vllm
that referenced
this pull request
Nov 4, 2024
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Richard Liu <[email protected]>
bigPYJ1151
pushed a commit
to bigPYJ1151/vllm
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Nick Hill <[email protected]>
DarkLight1337
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Nick Hill <[email protected]>
hissu-hyvarinen
pushed a commit
to ROCm/vllm
that referenced
this pull request
Nov 6, 2024
Signed-off-by: Nick Hill <[email protected]>
JC1DA
pushed a commit
to JC1DA/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Nick Hill <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Nick Hill <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make batch generators sparse