Skip to content

[Kernel] add kernel for FATReLU #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2024
Merged

[Kernel] add kernel for FATReLU #9610

merged 5 commits into from
Oct 24, 2024

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Oct 23, 2024

ping @mgoin
also cc @streaver91

@github-actions
Copy link

github-actions bot commented Oct 23, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Implement the FatReLU kernel
7f841d4 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
n:Add sign
a5afa6e 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
Test sign
2a42806 
Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee
test sign-off
506c3f5 
Signed-off-by: Jee Jee Li <[email protected]>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 23, 2024
@jeejeelee
Copy link
Collaborator Author

jeejeelee commented Oct 23, 2024

@mgoin It seems the failures on CI are due to network issues

@jeejeelee
Modify comment
b9bf559 
Signed-off-by: Jee Jee Li <[email protected]>
mgoin
mgoin approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, thanks for the test

tlrmchlsmth
tlrmchlsmth approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward PR and looks good to me, thanks for the contribution!

@DarkLight1337 DarkLight1337 merged commit 295a061 into vllm-project:main Oct 24, 2024
79 checks passed
@jeejeelee jeejeelee deleted the fatrelu-kernel branch October 24, 2024 09:04
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@jeejeelee
[Kernel] add kernel for FATReLU (vllm-project#9610)
23de555 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Erkin Sagiroglu <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@jeejeelee @FerdinandZhong
[Kernel] add kernel for FATReLU (vllm-project#9610)
9f4c844 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: qishuai <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@jeejeelee @sumitd2
[Kernel] add kernel for FATReLU (vllm-project#9610)
7a91fb7 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@jeejeelee @LeiWang1999
[Kernel] add kernel for FATReLU (vllm-project#9610)
7c2c297 
Signed-off-by: Jee Jee Li <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeejeelee @tlrmchlsmth @mgoin @DarkLight1337