Skip to content

[Frontend] Support custom request_id from request #9550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 5 commits into from
Oct 22, 2024
Merged

[Frontend] Support custom request_id from request #9550

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36fbdfe
Support input request_id
guoyuhong Oct 21, 2024
a0aaea0
python lint
guoyuhong Oct 21, 2024
df8dfe2
python lint
guoyuhong Oct 21, 2024
d1644d0
Address comments
guoyuhong Oct 22, 2024
8ac9aa3
python lint
guoyuhong Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vllm/entrypoints/openai/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ class ChatCompletionRequest(OpenAIBaseModel):
spaces_between_special_tokens: bool = True
truncate_prompt_tokens: Optional[Annotated[int, Field(ge=1)]] = None
prompt_logprobs: Optional[int] = None
request_id: str = Field(default_factory=lambda: f"{random_uuid()}")
Comment thread
DarkLight1337 marked this conversation as resolved.
Outdated
# doc: end-chat-completion-sampling-params

# doc: begin-chat-completion-extra-params
Expand Down
3 changes: 2 additions & 1 deletion vllm/entrypoints/openai/serving_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ async def create_chat_completion(
"\"auto\" tool choice requires "
"--enable-auto-tool-choice and --tool-call-parser to be set")

request_id = f"chat-{random_uuid()}"
request_id = (f"chat-{request.request_id}" if request.request_id
is not None else f"chat-{random_uuid()}")
Comment thread
DarkLight1337 marked this conversation as resolved.
Outdated

request_metadata = RequestResponseMetadata(request_id=request_id)
if raw_request:
Expand Down