-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Print warnings related to mistral_common
tokenizer only once
#9468
[Bugfix] Print warnings related to mistral_common
tokenizer only once
#9468
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this!
…ce (vllm-project#9468) Signed-off-by: charlifu <[email protected]>
…ce (vllm-project#9468) Signed-off-by: Vinay Damodaran <[email protected]>
…ce (vllm-project#9468) Signed-off-by: Alvant <[email protected]>
…ce (vllm-project#9468) Signed-off-by: Amit Garg <[email protected]>
…ce (vllm-project#9468) Signed-off-by: qishuai <[email protected]>
…ce (vllm-project#9468) Signed-off-by: Sumit Dubey <[email protected]>
…ce (vllm-project#9468) Signed-off-by: Maxime Fournioux <[email protected]>
These warnings are printed with every request (regardless of the presence/absence of
add_generation_prompt
/continue_final_message
in the request body). There is no point in doing this, it only pollutes the log.