Skip to content

[XPU] avoid triton import for xpu #9440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 24, 2024
Merged

[XPU] avoid triton import for xpu #9440

merged 3 commits into from
Oct 24, 2024

Conversation

@yma11
Copy link
Contributor

@yma11 yma11 commented Oct 17, 2024

avoid triton import for xpu as we don't take triton as dependency.

@github-actions
Copy link

github-actions bot commented Oct 17, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yma11 yma11 force-pushed the triton_import branch 2 times, most recently from 701572f to 966cb9b Compare October 18, 2024 07:07
@yma11
Copy link
Contributor Author

yma11 commented Oct 21, 2024

@youkaichao can you help review this minor change? Thanks.

jikunshang
jikunshang approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jikunshang jikunshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DarkLight1337
DarkLight1337 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, let's get this merged!

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 24, 2024
@youkaichao youkaichao enabled auto-merge (squash) October 24, 2024 03:28
@youkaichao youkaichao merged commit 056a68c into vllm-project:main Oct 24, 2024
68 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@yma11 @DarkLight1337 @Alvant
[XPU] avoid triton import for xpu (vllm-project#9440)
7f1a962 
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Alvant <[email protected]>
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@yma11 @DarkLight1337
[XPU] avoid triton import for xpu (vllm-project#9440)
b51f0c5 
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Erkin Sagiroglu <[email protected]>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@yma11 @DarkLight1337 @FerdinandZhong
[XPU] avoid triton import for xpu (vllm-project#9440)
0b9bac0 
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: qishuai <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@yma11 @DarkLight1337 @sumitd2
[XPU] avoid triton import for xpu (vllm-project#9440)
b0f0653 
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@yma11 @DarkLight1337 @LeiWang1999
[XPU] avoid triton import for xpu (vllm-project#9440)
126f08e 
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
@yma11 yma11 deleted the triton_import branch May 27, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@jikunshang jikunshang jikunshang approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yma11 @DarkLight1337 @jikunshang @youkaichao