-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][Kernel] Prevent integer overflow in fp8 dynamic per-token quantize kernel #9425
[Bugfix][Kernel] Prevent integer overflow in fp8 dynamic per-token quantize kernel #9425
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
…antize kernel (vllm-project#9425) Signed-off-by: charlifu <[email protected]>
…antize kernel (vllm-project#9425) Signed-off-by: Vinay Damodaran <[email protected]>
…antize kernel (vllm-project#9425) Signed-off-by: Alvant <[email protected]>
…antize kernel (vllm-project#9425) Signed-off-by: Amit Garg <[email protected]>
…antize kernel (vllm-project#9425) Signed-off-by: qishuai <[email protected]>
…antize kernel (vllm-project#9425) Signed-off-by: Sumit Dubey <[email protected]>
…antize kernel (vllm-project#9425) Signed-off-by: Maxime Fournioux <[email protected]>
After seeing #9391, I ran
grep -r "token_idx \* hidden_size" csrc
, and found that the same 32-bit integer overflow may happen in the fp8 dynamic quantize kernel as well.This PR prevents this from happening by using
int64_t
instead