-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] remove .github from .dockerignore, add dirty repo check #9375
Conversation
including this in .dockerignore results having a dirty repo when copying the source while building the image.
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Can we add a clause in Dockerfile to assert the git repo is in non dirty state (gated by a flag off by default, and turned on by release, similar to wheel size check, although wheel size check is on by default) |
Actually in all our ci it shouldn't be dirty |
Added a clause to check for git repo status (dirty and presence of tags) under the |
…rty before building
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert the non default Dockerfile changes? I believe given those don't get triggered in release pipeline we don't need to do that.
[2024-10-17T17:13:54Z] #18 [build 4/8] RUN --mount=type=bind,source=.git,target=.git if [ "1" != 0 ]; then bash tools/check_repo.sh ; fi | [2024-10-17T17:13:55Z] #18 0.638 v0.6.3-10-gb007d160 Build pass here https://buildkite.com/vllm/release/builds/1409#01929b76-e6c7-479c-9b7c-f6e25653eec9 |
…llm-project#9375) Signed-off-by: charlifu <[email protected]>
…llm-project#9375) Signed-off-by: Vinay Damodaran <[email protected]>
…llm-project#9375) Signed-off-by: Alvant <[email protected]>
…llm-project#9375) Signed-off-by: Amit Garg <[email protected]>
…llm-project#9375) Signed-off-by: qishuai <[email protected]>
…llm-project#9375) Signed-off-by: Maxime Fournioux <[email protected]>
…llm-project#9375) Signed-off-by: Tyler Michael Smith <[email protected]>
Including
.github
in.dockerignore
results having a dirty repo when copying the source while building the image, causing the version stringsetuptools-scm
not to match tags exactly.Also include
tools/check_repo.sh
to check repo status before building.See context here