-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[Misc] Move device options to a single place #8322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I once found this was annoying too so thanks for this.
@comaniac Test failures seem like unrelated flakes, and I don't have the required bits on Buildkite to retry a run :) |
Signed-off-by: Alvant <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
I noticed some of the devices available for
vllm
proper were not available for benchmarks.This PR moves the triplicated list of available devices to a single place.