Skip to content

[Misc] Move device options to a single place #8322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 10, 2024

I noticed some of the devices available for vllm proper were not available for benchmarks.

This PR moves the triplicated list of available devices to a single place.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@akx
Copy link
Contributor Author

akx commented Sep 10, 2024

The buildkite/fastcheck/pr/amd-openai-compatible-tool-use check error seems unrelated to this (a JSON decode error)...

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I once found this was annoying too so thanks for this.

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 11, 2024
@akx akx requested a review from comaniac September 11, 2024 16:13
@comaniac comaniac enabled auto-merge (squash) September 11, 2024 16:29
@akx
Copy link
Contributor Author

akx commented Sep 11, 2024

@comaniac Test failures seem like unrelated flakes, and I don't have the required bits on Buildkite to retry a run :)

@simon-mo simon-mo disabled auto-merge September 11, 2024 20:25
@simon-mo simon-mo merged commit 8baa454 into vllm-project:main Sep 11, 2024
51 of 53 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Sep 12, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
@akx akx deleted the device-options branch April 10, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants