-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[Speculative Decoding] Test refactor #8317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Speculative Decoding] Test refactor #8317
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the great simplification! the code looks much better now.
for the test failure I disabled, to reproduce and investigate, run the following in L4 machines: docker run -it --gpus all --ipc=host -e HF_TOKEN -v ~/.cache/huggingface:/root/.cache/huggingface public.ecr.aws/q9t5s3a7/vllm-ci-test-repo:f3d79ad8513645851909fc9ea217a9ad0c413427
pytest -v -s tests/spec_decode/e2e/test_multistep_correctness.py -k "test_spec_decode_e2e_greedy_correctness_tiny_model_bs1 or test_spec_decode_e2e_with_detokenization" I find the problem is the spec decode metrics are not collected. vllm/vllm/engine/llm_engine.py Lines 1900 to 1905 in 7015417
after these lines, cc @comaniac if you have bandwidth to investigate in the future. |
Co-authored-by: youkaichao <[email protected]>
Co-authored-by: youkaichao <[email protected]> Signed-off-by: Alvant <[email protected]>
Co-authored-by: youkaichao <[email protected]> Signed-off-by: LeiWang1999 <[email protected]>
Refactor Speculative Decoding tests to remove AsyncLLMEngine. Related to #8126.