Skip to content

[Bugfix] Fix weight loading issue by rename variable. #8293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

wenxcs
Copy link
Contributor

@wenxcs wenxcs commented Sep 9, 2024

Fix #8186: [Bug]: Phi-3.5-MoE-Instruct on vLLM produces weird strings

Some commit introduced the change of weight loading procedure. PhiMoE should also modify this weight names to load weight into correct tensor.

@wenxcs
Copy link
Contributor Author

wenxcs commented Sep 9, 2024

/ready

Copy link

github-actions bot commented Sep 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 9, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches up with other usage, thanks!

@lhcavalcanti
Copy link

Hi @wenxcs, is there any plan to merge this one soon and release a version with this fix?

Thanks.

@mgoin mgoin merged commit a480939 into vllm-project:main Sep 12, 2024
49 checks passed
@mgoin
Copy link
Member

mgoin commented Sep 12, 2024

Thanks for the ping @lhcavalcanti

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Phi-3.5-MoE-Instruct on vLLM produces weird strings
3 participants