Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix incorrect vocal embedding shards for GGUF model in tensor parallelism #7954

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[Bugfix] Fix incorrect vocal embedding shards for GGUF model in tensor parallelism #7954

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2e76d8
fix incorrect logits computation for tp_size>1
Isotr0py Aug 28, 2024
c04d595
fix gguf tp VocabParallelEmbedding
Isotr0py Aug 29, 2024
1d24213
fix a typo
Isotr0py Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vllm/model_executor/layers/vocab_parallel_embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,10 @@ def weight_loader(self, param: Parameter, loaded_weight: torch.Tensor):
param.weight_type = loaded_weight.item()
return
elif isinstance(param, UninitializedParameter):
param.materialize(loaded_weight.shape, dtype=loaded_weight.dtype)
shape = list(loaded_weight.shape)
if output_dim is not None:
shape[output_dim] = shape[output_dim] // self.tp_size
param.materialize(tuple(shape), dtype=loaded_weight.dtype)

# If parameter does not have output dim, then it should
# be copied onto all gpus (e.g. g_idx for act_order gptq).
Expand Down
Loading