[Bugfix][VLM] Fix incompatibility between #7902 and #7230 #7948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e support in LLaVA-NeXT
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
DarkLight1337
changed the title
DarkLight1337
added
the
ready
DarkLight1337
commented
Aug 28, 2024
Comment on lines
+515
to
+527
| expected_dims = (2, ) | ||
|
|
||
| def _validate_shape(d: torch.Tensor): | ||
| actual_dims = tuple(d.shape) | ||
|
|
||
| if actual_dims != expected_dims: | ||
| expected_expr = str(expected_dims) | ||
| raise ValueError( | ||
| f"The expected shape of image sizes per image per batch " | ||
| f"is {expected_expr}. You supplied {tuple(d.shape)}.") | ||
|
|
||
| for d in data: | ||
| _validate_shape(d) |
There was a problem hiding this comment.
While this is more complex, the error message becomes consistent with the one for pixel_values.
|
Thanks for the fix! |
kushanam
pushed a commit
to kushanam/vllm
that referenced
this pull request
Aug 28, 2024
kushanam
pushed a commit
to kushanam/vllm
that referenced
this pull request
Aug 28, 2024
|
Thank you for the fix! Sorry about that. |
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…project#7230 (vllm-project#7948) Signed-off-by: Alvant <[email protected]>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
…project#7230 (vllm-project#7948) Signed-off-by: LeiWang1999 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an incompatibility between multimodal tensor stacking and multi-image support in LLaVA-NeXT and InternVL which causes the VLM CI to fail.
It also updates the docstrings about the input shapes which have become outdated since #7230.
The issue failed to be caught in #7902 because the changes from #7230 were not merged into its feature branch prior to merging #7902.