Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #7509 #7887

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Revert #7509 #7887

merged 3 commits into from
Aug 27, 2024

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Aug 26, 2024

Revert #7509

This should also cover group size 6.

cc @elfiegg @learninmou @yzh119

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 26, 2024
vllm/attention/backends/flashinfer.py Outdated Show resolved Hide resolved
vllm/attention/backends/flashinfer.py Outdated Show resolved Hide resolved
@comaniac comaniac merged commit 9606c71 into main Aug 27, 2024
44 checks passed
@comaniac comaniac deleted the comaniac-patch-1 branch August 27, 2024 07:16
triple-Mu pushed a commit to triple-Mu/vllm_official that referenced this pull request Sep 4, 2024
Jeffwan pushed a commit to aibrix/vllm that referenced this pull request Sep 19, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants