[CI/Build] Reorganize models tests #7820
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
|
For some reason, splitting them up actually causes the multimodal tests to take longer than before... Edit: It's probably because Qwen-VL tests are now being run as well. Let me disable them for now... |
|
|
|
|
DarkLight1337
changed the title
|
Seems to be a temporary network issue, since the test times are back to normal now. Let's merge this before working on |
DarkLight1337
added
the
ready
| @@ -311,11 +332,11 @@ steps: | |||
| - tests/distributed/ | |||
| commands: | |||
| - # the following commands are for the first node, with ip 192.168.10.10 (ray environment already set up) | |||
| - VLLM_TEST_SAME_HOST=0 torchrun --nnodes 2 --nproc-per-node=2 --rdzv_backend=c10d --rdzv_endpoint=192.168.10.10 distributed/test_same_node.py | |||
| - VLLM_TEST_SAME_HOST=0 torchrun --nnodes 2 --nproc-per-node=2 --rdzv_backend=c10d --rdzv_endpoint=192.168.10.10 distributed/test_same_node.py | grep -q 'Same node test passed' | |||
There was a problem hiding this comment.
Since I have added an if __name__ == "__main__" guard to avoid executing the code during test collection, I use grep to ensure that the code inside is actually run during the test.
|
LGTM in general, thanks for the huge efforts! My only question is w.r.t. the fork of process for every test (which is resolved in the comments). |
|
Nice reorganization |
Signed-off-by: Alvant <[email protected]>
Signed-off-by: Amit Garg <[email protected]>
Signed-off-by: LeiWang1999 <[email protected]>
To avoid timeout error, split up the models tests as per #7439 (comment).
Also, I have moved the distributed basic correctness and model tests into the respective files for single-GPU case to avoid fragmentation of the test logic.
Note: The
core_modelflag isn't used in CI yet.cc @khluu