-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add multi-step support to LLMEngine #7789
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @SolitaryThinker
benchmarks/benchmark_throughput.py
Outdated
num_scheduler_steps=8, | ||
use_v2_block_manager=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, added as arg params
examples/offline_inference.py
Outdated
@@ -11,7 +11,7 @@ | |||
sampling_params = SamplingParams(temperature=0.8, top_p=0.95) | |||
|
|||
# Create an LLM. | |||
llm = LLM(model="facebook/opt-125m") | |||
llm = LLM(model="facebook/opt-125m", tensor_parallel_size=2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
tests/multi_step/test_correctness.py
Outdated
async def test_multi_step_async_llm(example_prompts, model: str, tp_size: int, | ||
pp_size: int, eager_mode: int, | ||
num_scheduler_steps: int, | ||
num_prompts: int): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this as unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, great for offline throughput
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt thanks @alexm-neuralmagic!
a2ee9d3
to
ec2c589
Compare
Signed-off-by: Alvant <[email protected]>
This PR adds multi-step support to the LLM Engine class. The new multi-step methods that were originally added to async_llm_engine were moved to llm_engine, since async_llm_engine inherits from llm_engine.